The Senate voted Thursday to make one of President Trump’s most controversial picks to date, Steven Menashi, a lifetime federal judge.